Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding publish collisions #318

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Avoiding publish collisions #318

merged 1 commit into from
Mar 27, 2023

Conversation

therealryan
Copy link
Collaborator

#294 enabled the publishing of test reports from PR branches. This morning's bolus of dependabot PRs exposed a weakness - a bunch of the publish jobs failed as they were trying to update the pages branch at the same time, so there was a race condition where the losers failed on the git push - their commit history was suddenly out-of-date.

This change should mitigate that via the job-level concurrency control - now only one instance of the publish job should have access to the pages branch at a time,

@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@therealryan therealryan merged commit fb548f4 into main Mar 27, 2023
@therealryan therealryan deleted the pages_mutex branch March 27, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant