Mermaid details #337
Merged
Mermaid details #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
therealryan
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The artifact structure diagrams are kind of large, so we used to display them in a
<details>block to disrupt the page less.At some point github changed something on their end which broke this usage (diagrams in
<details>blocks were displayed with zero height), so we had to #196 to just display the diagrams all the time.We raised an issue with github to get their regression fixed. That issue is still open, but it looks like the problem has gone away. ¯\_(ツ)_/¯
So, we're restoring our usage of
<details>.Also in this changeset, some documentation fixes: