Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some wrong names for hashes and MGF in the manual #30

Closed
ceridwen opened this issue Apr 13, 2021 · 4 comments
Closed

Some wrong names for hashes and MGF in the manual #30

ceridwen opened this issue Apr 13, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ceridwen
Copy link

Under https://github.com/Mastercard/pkcs11-tools/blob/master/docs/MANUAL.md#p11wrap-and-p11unwrap,

mgf=CKG_MGF1_SHA1|CKG_MGF1_SHA256|CKG_MGF_SHA384|CKG_MGF_SHA512 - MGF parameter, default is CKG_MGF1_SHA1
hash=CKM_SHA_1|CKM_SHA224|CKM_SHA256|CKM_SHA384|CKM_SHA512 - hashing alg. argument, default is CKM_SHA_1

These are not the same as the mechanisms listed in the standard. Yesterday I was trying unwrapping and wrapping and couldn't figure out why I was getting errors until I looked the mechanisms up.

@keldonin keldonin self-assigned this Apr 14, 2021
@keldonin
Copy link
Contributor

Hi @ceridwen, the problem I see is in the documentation, where CKG_MGF_SHAxxx should be CKG_MGF1_SHAxxx instead. I'll fix that, is there anything else I may have missed?

@keldonin keldonin added the bug Something isn't working label Apr 14, 2021
@keldonin
Copy link
Contributor

Actually the documentation is inferred from the help string produced when specifying the -h argument to a command, which means that the documentation in the commands p11wrap, p11keygen and p11rewrap must be adjusted as well.

keldonin added a commit that referenced this issue Apr 14, 2021
…ygen` were incorrect. The documentation has also been adjusted (Issue #30).
@keldonin
Copy link
Contributor

The changes have been added to the masterbranch, but not issued as a new release yet. Please check it out to see if it addresses your issue entirely.

Thank you for your contribution,

@ceridwen
Copy link
Author

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants