Issue #94 UTF8Utils::countChars() - extra bad perfomance with iconv_s… #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith iconv_strlen()
There was a problem hiding this comment.
I'd like to have as wide of support as possible. Instead of removing iconv_strlen all together can you re-order them so mb_strlen is tried first. Then, if mb_strlen isn't present it can still try iconv_strlen.
…ith iconv_strlen()
|
Hi, @mattfarina I've updated commit as you said, sorry for long delay. |
|
@layershifter thanks! |
goetas
added a commit
that referenced
this pull request
Feb 6, 2016
Issue #94 UTF8Utils::countChars() - extra bad perfomance with iconv_s…
|
Changes Unknown when pulling 9d94fa5 on layershifter:2.x into ** on Masterminds:2.x**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #94