git: remove extra quotes in submodule export #63
Conversation
on the cli, one uses the extra single quotes to ensure the whole cmd is passed as a single arg despite containing spaces, but when passing args in a structured call like this, it isn't needed. Fixes Masterminds/glide#745
|
[INFO] --> Exporting github.com/Sirupsen/logrus |
|
Thanks for the contribution. |
| @@ -385,7 +385,7 @@ func (s *GitRepo) ExportDir(dir string) error { | |||
| return NewLocalError("Unable to export source", err, string(out)) | |||
| } | |||
| // and now, the horror of submodules | |||
| out, err = s.RunFromDir("git", "submodule", "foreach", "--recursive", "'git checkout-index -f -a --prefix=\""+filepath.Join(dir, "$path")+"\"'") | |||
| out, err = s.RunFromDir("git", "submodule", "foreach", "--recursive", "git checkout-index -f -a --prefix=\""+filepath.Join(dir, "$path")+"/\"") | |||
There was a problem hiding this comment.
By the way, is the newly added / (forward slash) character at the end intentional?
I ask because the commit message only mentions removing single quotes, nothing about adding a slash.
There was a problem hiding this comment.
Whoops, yes, it is, I just forgot to mention it in the message / I probably should have included a test.
I found via experimentation that without it, the submodule's files end up prefixed and in the parent dir.
on the cli, one uses the extra single quotes to ensure the whole cmd is passed as a single arg despite
containing spaces, but when passing args in a structured call like this, it isn't needed, and instead causes this error:
Fixes Masterminds/glide#745