Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean topics and schema subjects datagen creates #55

Merged

Conversation

chuck-alt-delete
Copy link
Contributor

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🚩 Other

Description

delete topics and schema subjects using the --clean option

Related Tickets & Documents

closes #50

Added to documentation?

  • 📜 readme
  • 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

@chuck-alt-delete
Copy link
Contributor Author

I plan on doing a bigger documentation update where I go through an end-to-end example. The --clean option would be part of it.

Copy link
Collaborator

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙌

@chuck-alt-delete chuck-alt-delete merged commit 19cdbd2 into MaterializeInc:main Mar 4, 2023
@chuck-alt-delete chuck-alt-delete deleted the feature/clean branch March 10, 2023 19:27
recursethis pushed a commit to recursethis/materialize-datagen that referenced this pull request Feb 26, 2024
…izeInc#55)

* implement feature to clean topics and schema subjects datagen creates

* better error handling and soft delete the subject

* limit the axios error message for schema registry

* log the names of the deleted topics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Clean up topics and schema subjects
2 participants