Convert to TypeScript

[bobbyiliev]

What type of PR is this? (check all applicable)

• ♻️ Refactor
• ✨ Feature
• 🐛 Bug Fix
• 👷 Optimization
• 📝 Documentation Update
• 🚩 Other

Description

Initial conversation to TS.

Related Tickets & Documents

Closes #60

Added to documentation?

• 📜 readme
• 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

[sjwiesman]

Wow you are fast. Why is this marked in progress? We don't need to make everything idiomatic in this PR. Getting the build system updated is most important. Everything else can be piecemeal.

[sjwiesman]

If this compiles and works, I'm inclined to say merge and increment.

[bobbyiliev]

Wow you are fast. Why is this marked in progress? We don't need to make everything idiomatic in this PR. Getting the build system updated is most important. Everything else can be piecemeal.

There is one bug that the integration tests caught:

| ✔  Schema registered!  Subject: mz_datagen_comments-value, ID: 4
| 
| /app/node_modules/@kafkajs/confluent-schema-registry/dist/SchemaRegistry.js:153
|             throw new errors_1.ConfluentSchemaRegistryArgumentError(`Invalid registryId: ${JSON.stringify(registryId)}`);
|                   ^
| 
| ConfluentSchemaRegistryArgumentError: Invalid registryId: undefined
|     at SchemaRegistry.encode (/app/node_modules/@kafkajs/confluent-schema-registry/dist/SchemaRegistry.js:153:19)
|     at file:///app/dist/src/schemas/schemaRegistry.js:65:44

Wanted to fix that first before merging

[chuck-alt-delete]

That bug (I think) and a couple of others are fixed in my open PR. Maybe we can merge that one first?

[bobbyiliev]

That bug (I think) and a couple of others are fixed in my open PR. Maybe we can merge that one first?

Ok sounds good, let's merge #62 and then I'll rebase and go from there!

[chuck-alt-delete]

Ok done!

[bobbyiliev]

Just pushed the changes from main. Seems like we are still hitting that error:

| ✔  Registering Avro schema...  
| 
| file:///app/dist/src/schemas/schemaRegistry.js:17
|         schema.name = `name${i++}`;
|                     ^
| 
| TypeError: Cannot create property 'name' on string 'string'

[chuck-alt-delete]

That looks like a new error

[bobbyiliev]

That looks like a new error

Ah yes, no that was actually the initial error, before I started debugging and trying out stuff