Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate dates to strings for easy avro output #93

Merged

Conversation

chuck-alt-delete
Copy link
Contributor

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🚩 Other

Description

I translate Date objects generated by Faker to ISO 8601 formatted string to make it easy to output Avro formatted records that contain dates.

Related Tickets & Documents

closes #68

Added to documentation?

  • 📜 readme
  • 🙅 no documentation needed

@chuck-alt-delete chuck-alt-delete added the enhancement New feature or request label Apr 6, 2023
@chuck-alt-delete chuck-alt-delete self-assigned this Apr 6, 2023
Copy link
Collaborator

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chuck-alt-delete chuck-alt-delete merged commit f38c350 into MaterializeInc:main Apr 6, 2023
@chuck-alt-delete chuck-alt-delete deleted the feature/dates branch April 6, 2023 21:50
recursethis pushed a commit to recursethis/materialize-datagen that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support Date types for Avro
2 participants