Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG-95]: Fix parseAvroSchema for record type fields #98

Conversation

YajneshPadiyar
Copy link
Contributor

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🚩 Other

Description

Fix Bug 95

Related Tickets & Documents

Bug 95

Added to documentation?

  • 📜 readme
  • 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

@YajneshPadiyar
Copy link
Contributor Author

@bobbyiliev Pelase review this PR. I had to create a new PR as the previous would not allow me to sign the CLA.

@bobbyiliev bobbyiliev self-requested a review April 20, 2023 10:03
Copy link
Collaborator

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this again! It looks great! Thank you again for opening another PR with the fix!

@bobbyiliev bobbyiliev merged commit 2a949ea into MaterializeInc:main Apr 20, 2023
recursethis pushed a commit to recursethis/materialize-datagen that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants