This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Pull upstream #10
Merged
Pull upstream #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow joins to produce arbitrary containers Add a `join_traces_core` function that allows the caller to specify the output stream container type. The existing `join_traces` function forces it to be vectors, by virtue of wrapping the output in a collection. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> * Remove `join_traces_core` Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> --------- Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
* Split default merge batcher This change splits the default merge batcher implementation into a type that maintains the outer part of its algorithm, specifically knows how to maintain chains, and an inner part that knows how to maintain the individual batches in chains. The benefit is that the outer part does not need to know about the contents of the containers it holds on to because that's encapsulated in the inner trait's implementation. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> * Undo some changes, rip out old columnated batcher Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> * Address feedback Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> * Formatting and renaming Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> * Address feedback Signed-off-by: Moritz Hoffmann <antiguru@gmail.com> --------- Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
join_traces can produce arbitrary containers. --------- Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.