persist: in persist_source, do very fine-grained output activation #16390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if there where too many parts at the same timestamp we would be holding activated output handles and sessions across await points for too long, which can prevent flushing of the shared timely output buffer.
petrosagg
approved these changes
Nov 30, 2022
guswynn
reviewed
Nov 30, 2022
Comment on lines
429
to
436
| // Do very fine-grained output activation/session | ||
| // creation to ensure that we don't hold activated | ||
| // outputs or sessions across await points, which | ||
| // would prevent messages from being flushed from | ||
| // the shared timely output buffer. | ||
| let mut output_handle = update_output.activate(); | ||
| let mut update_session = output_handle.session(&cap); | ||
|
|
There was a problem hiding this comment.
this is still held across a yield_now await point below, you probably need to open a new { } around these + the give_vec
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if there where too many parts at the same timestamp we would be holding activated output handles and sessions across await points for too long, which can prevent flushing of the shared timely output buffer.