Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapter: stash migration cleanup #18752

Merged
merged 1 commit into from
Apr 18, 2023
Merged

adapter: stash migration cleanup #18752

merged 1 commit into from
Apr 18, 2023

Conversation

maddyblue
Copy link
Contributor

Clear various stash migrations. This allows us to make the current Rust types more correct (no Option).

Motivation

  • This PR refactors existing code.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:
    • n/a

@maddyblue maddyblue requested a review from a team as a code owner April 13, 2023 04:18
@maddyblue
Copy link
Contributor Author

Nightly of this running at https://buildkite.com/materialize/nightlies/builds/2206.

jkosh44
jkosh44 approved these changes Apr 13, 2023
View reviewed changes
src/adapter/src/catalog/storage.rs Show resolved Hide resolved
@maddyblue maddyblue force-pushed the stash-migration-cleanup branch 3 times, most recently from 36d7474 to 355c780 Compare April 18, 2023 06:38
@maddyblue
Copy link
Contributor Author

Can you take another look? I believe I correctly merged the migration into the initial one. Also had to jigger some tests.

jkosh44
jkosh44 approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating the tests.

@maddyblue maddyblue merged commit 6f15898 into MaterializeInc:main Apr 18, 2023
@maddyblue maddyblue deleted the stash-migration-cleanup branch April 18, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkosh44 jkosh44 jkosh44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maddyblue @jkosh44