Remove collapsible_if
and collapsible_else_if
lints
#18797
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added these lints two years ago, the justification I gave was "semantically wrong level of nesting". However, I have now realized that these lints can actually enforce a semantically wrong level of nesting. For example, the following natural code is rejected by the lint.
Thus, I am now of the opinion that my initial decision to include these lints was a mistake, and would like to remove them.
Discussion in Slack here.