Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,docs: in cloudtest.md, add small troubleshooting section #18838

Merged
merged 1 commit into from
Apr 19, 2023
Merged

test,docs: in cloudtest.md, add small troubleshooting section #18838

merged 1 commit into from
Apr 19, 2023

Conversation

aljoscha
Copy link
Contributor

Motivation

Might save time in the future!

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@aljoscha
Copy link
Contributor Author

fyi, @benesch since you wrote large parts of this as well

philip-stoev
philip-stoev approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@philip-stoev philip-stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aljoscha aljoscha merged commit df4cd33 into MaterializeInc:main Apr 19, 2023
@aljoscha aljoscha deleted the test-cloudtest-docs branch April 19, 2023 13:13
benesch
benesch reviewed Apr 19, 2023
View reviewed changes
Copy link
Member

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Aljoscha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesch benesch benesch left review comments

@philip-stoev philip-stoev philip-stoev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aljoscha @benesch @philip-stoev