Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: support array casting #18857

Merged
merged 9 commits into from
Apr 21, 2023
Merged

sql: support array casting #18857

merged 9 commits into from
Apr 21, 2023

Conversation

rkrishn7
Copy link
Contributor

Motivation

  • This PR adds a known-desirable feature.
    • Solves MaterializeInc/database-issues#5533

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@rkrishn7 rkrishn7 requested a review from a team as a code owner April 20, 2023 06:32
@rkrishn7 rkrishn7 requested a review from a team April 20, 2023 06:32
jkosh44
jkosh44 reviewed Apr 20, 2023
View reviewed changes
Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, so much for the PR! I had a couple of comments.

src/expr/src/scalar/func/impls/array.rs Outdated Show resolved Hide resolved
test/sqllogictest/arrays.slt Outdated Show resolved Hide resolved
test/sqllogictest/arrays.slt Show resolved Hide resolved
jkosh44
jkosh44 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again for the PR! You have one lint issue, but once that's resolved I'll merge.

@jkosh44 jkosh44 merged commit 5cc8fb2 into MaterializeInc:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkosh44 jkosh44 jkosh44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrishn7 @jkosh44