Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: add config var to only turn on backpressure for disk upsert sources #20888

Merged
merged 1 commit into from
Jul 31, 2023
Merged

storage: add config var to only turn on backpressure for disk upsert sources #20888

merged 1 commit into from
Jul 31, 2023

Conversation

guswynn
Copy link
Contributor

@guswynn guswynn commented Jul 31, 2023

I noticed we might want this to safely roll backpressure out.

Motivation

  • This PR fixes a previously unreported bug.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@guswynn guswynn requested review from a team and moulimukherjee July 31, 2023 19:49
moulimukherjee
moulimukherjee approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@moulimukherjee moulimukherjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@guswynn guswynn enabled auto-merge (rebase) July 31, 2023 22:53
@guswynn guswynn merged commit 12dfa01 into MaterializeInc:main Jul 31, 2023
@guswynn guswynn deleted the disk-only-backpressure branch July 31, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moulimukherjee moulimukherjee moulimukherjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guswynn @moulimukherjee