platform-checks: Perform validate() twice in the CI #20901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrainer-materialize
approved these changes
Aug 2, 2023
Comment on lines
+165
to
+166
| # Validate again so that introducing non-idempotent validate()s | ||
| # will cause the CI to fail. |
Comment on lines
542
to
552
| + self._drop_objects("owner_role_01", 1, expensive=True) | ||
| + self._drop_objects("other_owner", 2, expensive=True) | ||
| + self._drop_objects("owner_role_01", 3) | ||
| + self._drop_objects("other_owner", 4) | ||
| + self._drop_objects("owner_role_01", 5) | ||
| + self._drop_objects("other_owner", 6) | ||
| + self._drop_objects("owner_role_02", 7) | ||
| + self._drop_objects("other_owner", 8) | ||
| + self._drop_objects("owner_role_01", 9) | ||
| + self._drop_objects("owner_role_02", 10) | ||
| + self._drop_objects("owner_role_03", 11) |
There was a problem hiding this comment.
This was removed because it is in the validate part, right?
There was a problem hiding this comment.
Yes, it was doing DROP in the validate() section.
There was a problem hiding this comment.
Or maybe I misunderstood the entire test. It still fails anyway, so there is more to it.
There was a problem hiding this comment.
nevermind, figured it out. all green now.
philip-stoev
force-pushed
the
platform-checks-validate-twice
branch
from
0873daa
to
4d3b059
Compare
Make sure at least one step in the per-push CI performs validate() twice. This will weed out any validate()s that are not idempotent. Previously, multiple validate() calls were only present in Nightly.
philip-stoev
force-pushed
the
platform-checks-validate-twice
branch
from
4d3b059
to
ba709aa
Compare
The validate() method needs to be idempotent
philip-stoev
force-pushed
the
platform-checks-validate-twice
branch
from
ba709aa
to
966559d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure at least one step in the per-push CI performs validate() twice. This will weed out any validate()s that are not idempotent.
Previously, multiple validate() calls were only present in Nightly.
Motivation
Nightly CI was failing if non-idempotent validate()s are introduced.