rename persist-txn to txn-wal #27242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkosh44
force-pushed
the
change-persist-txn-name
branch
5 times, most recently
from
c29fdd4
to
06d2684
Compare
jkosh44
force-pushed
the
change-persist-txn-name
branch
from
06d2684
to
49ad588
Compare
jkosh44
commented
May 23, 2024
| @@ -131,6 +130,7 @@ | |||
| /src/testdrive @MaterializeInc/testing | |||
| /src/timely-util @MaterializeInc/compute | |||
| /src/transform @MaterializeInc/compute | |||
| /src/txn-wal @aljoscha @danhhz @jkosh44 | |||
There was a problem hiding this comment.
I wasn't really sure what to put here. Maybe it's time to make a Pv2 team in GH?
jkosh44
force-pushed
the
change-persist-txn-name
branch
from
49ad588
to
f5ee216
Compare
danhhz
approved these changes
May 23, 2024
There was a problem hiding this comment.
Lgtm modulo the catalog changes and migration, I don't feel confident in my ability to reason about those, so it'd be lovely to get someone else to stamp that part
There were a couple name flips that I think probably could have stayed as they were before, but they were all marginal so I didn't bother nit-ing them
| @@ -131,6 +130,7 @@ | |||
| /src/testdrive @MaterializeInc/testing | |||
| /src/timely-util @MaterializeInc/compute | |||
| /src/transform @MaterializeInc/compute | |||
| /src/txn-wal @aljoscha @danhhz @jkosh44 | |||
maddyblue
approved these changes
May 23, 2024
…nge-persist-txn-name # Conflicts: # src/catalog/src/durable/upgrade.rs
…nge-persist-txn-name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR refactors existing code.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.