Acceptance tests #200
Acceptance tests #200
Conversation
| Config: testAccSchemaResource(schemaName), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| testAccCheckSchemaExists("materialize_schema.test"), | ||
| resource.TestCheckResourceAttr("materialize_schema.test", "name", schemaName), |
There was a problem hiding this comment.
A couple more attributes to include database_name and qualified_sql_name
| Config: testAccSourceLoadGeneratorResource(sourceLoadGeneratorName), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| testAccCheckSourceLoadGeneratorExists("materialize_source_load_generator.test"), | ||
| resource.TestCheckResourceAttr("materialize_source_load_generator.test", "name", sourceLoadGeneratorName), |
There was a problem hiding this comment.
There are a few other attributes we should track like the schema_name, database_name, qualified_sql_name, size, load_generator_type and the counter_options
There was a problem hiding this comment.
Goot catch! Just added the missing attributes for all of those resources! Let me know if you notice any other issues!
| Config: testAccTableResource(tableName), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| testAccCheckTableExists("materialize_table.test"), | ||
| resource.TestCheckResourceAttr("materialize_table.test", "name", tableName), |
There was a problem hiding this comment.
There are a few other attributes we should track like the schema_name, database_name, qualified_sql_name, column
| Config: testAccTypeResource(typeName), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| testAccCheckTypeExists("materialize_type.test"), | ||
| resource.TestCheckResourceAttr("materialize_type.test", "name", typeName), |
There was a problem hiding this comment.
There are a few other attributes we should track like the schema_name, database_name, qualified_sql_name, list_properties, map_properties, category
| Config: testAccViewResource(viewName), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| testAccCheckViewExists("materialize_view.test"), | ||
| resource.TestCheckResourceAttr("materialize_view.test", "name", viewName), |
There was a problem hiding this comment.
There are a few other attributes we should track like the schema_name, database_name, qualified_sql_name, statement
bobbyiliev
force-pushed
the
acceptance-tests
branch
from
59584b3
to
59c23c8
Compare
bobbyiliev
force-pushed
the
acceptance-tests
branch
from
f30b3f6
to
460852c
Compare
Adding more acceptance tests for the following resources: