Address some doc bugs #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatera
reviewed
Feb 4, 2024
| @@ -65,58 +70,27 @@ def get_title_html(self): | |||
|
|
|||
|
|
|||
| class DjangoDocumentation(Documentation, DjangoDocElement): | |||
There was a problem hiding this comment.
In the current mathics-core master branch, the Documentation class just has attributes related to the structure of the documentation, but not the part of loading DocParts from modules, which is included in MathicsMainDocumentation. This class should subclass this other class.
There was a problem hiding this comment.
This has been changed in master now. MathicsMainDocumentation was intended for testing only. LaTeX and HTML documentation are subclasses of Documentation.
mmatera
reviewed
Feb 4, 2024
mmatera
added a commit
that referenced
this pull request
Feb 4, 2024
rocky
force-pushed
the
address-some-doc-bugs
branch
2 times, most recently
from
9431b34
to
4bb4149
Compare
This needs the doc-code-rebased-rebased branch of Mathics core.
rocky
force-pushed
the
address-some-doc-bugs
branch
from
4bb4149
to
9182be1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tracks changes in Mathics3/mathics-core#984
We need this in order to fix document display after loading in Mathics3 Modules.