-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stdout standardization with output formatter #56
Conversation
This can be incrementally cherry-picked? Or will you do it one go? |
Cherry pick relevant commits back to staging @amydevs |
the first two commits have been cherrypicked into staging, remember to rebase after |
You should rebase this PR if you've cherrypicked, since then this will be left with just 1 commit! Otherwise it will be confusing. |
986f63b
to
ff9345e
Compare
ff9345e
to
7329770
Compare
There's still a problem here: #124 (comment) |
2a08f93
to
a986613
Compare
ce60f6d
to
6ff85b3
Compare
Can you expand the task list so we know how close we are finishing this? |
@amydevs where's the counter? |
3ad9573
to
9017511
Compare
…ts/CommandPermissions.ts` now uses `vaultPermissionList`
…er follow RPC response
fix: whitespace on `identities/CommandList` fix: `test/identities/trustUntrustList.test.ts`
962fa32
to
c38fb62
Compare
feat: `dict` formatter now also supports nested arrays fix: `outputFormatterDict` will not have incorrect output when an array element is a number
… their double newlines removed
…iate each notification
c38fb62
to
18d223c
Compare
Description
This PR fixes all the CLI stdout inconsistencies, this is kind of tedious and not critical at the moment though.
Changelog
{ claimId: string; url?: string }
.logger.info
so that it goes to stderrDict Format
This PR also implements changes to the dict format that allows for nesting.
Changes made to commands with this:
agent/CommandStatus
identities/CommandList
notificiations/CommandRead
Issues Fixed
dict
Format Nesting #158Tasks
list
formatted outputs to just be strings.list
formatted outputs to just bedicts
.json
formatted outputs to return structured POJO rather than just an array with the message itself.dict
formatFinal checklist