Refactor getConnectionToNode to use the correct ObjectMap structure

[joshuakarp]

Specification

Based on our sprint meeting today, the NodeConnectionMap and getConnectionToNode function in NodeManager needs to be refactored to match the ObjectMap pattern outlined by Roger.

Additionally, the generic ObjectMap diagram should also be updated to reflect the usage of this pattern:

There's a possibility to look into whether we can generalise the ObjectMap into Polykey, such that we don't have the repeated VaultMap and NodeConnectionMap using the same pattern, but this is low priority.

Additional context

• gist with ObjectMap pattern https://gist.github.com/CMCDragonkai/f58f08e7eaab0430ed4467ca35527a42
• original diagramming issue https://github.com/MatrixAI/js-polykey/issues/258 ObjectMap diagram currently found on the following wiki pages:
  • Vault Lifecycle
  • Node Connections

Tasks

1. Refactor getConnectionToNode
2. Change diagram

[CMCDragonkai]

I reckon the getObject function can be copy pasted right now and changed accordingly, or if you want, you can turn it into a higher order function and then acquire it. But there's only 2 places we're doing this right now so I think it's sufficient to copy paste. The diagram should then become linear with no loop involved. They all terminate at createObject.

Also consider changing the names to resource or be consistent with object.

[CMCDragonkai]

And remember objects in JS are mutable references!

[joshuakarp]

Diagram draft updated here https://github.com/MatrixAI/js-polykey/issues/258#issuecomment-955950837