Skip to content

Conversation

CDeltakai
Copy link
Contributor

@CDeltakai CDeltakai commented May 15, 2025

Description

This is a simple PR that just fixes any left over linting errors that were discovered by the new js-lint package.

Issues Fixed

Tasks

  • 1. Fix any remaining linting errors caught by the new linter

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CDeltakai
Copy link
Contributor Author

Replaced the blanket Function type with AnyFn = (...args: unknown[]) => unknown.
This silences no-unsafe-function-type linting rule and restores minimal type-safety (no implicit any) while leaving runtime behaviour untouched.

@CDeltakai CDeltakai merged commit 377ce02 into staging May 15, 2025
5 checks passed
@@ -56,7 +56,10 @@ function lock(...requests: Array<MultiLockRequest>) {
} else if (descriptor.set != null) {
kind = 'set';
}
const f: Function = descriptor[kind]; // eslint-disable-line @typescript-eslint/ban-types

type AnyFn = (...args: unknown[]) => unknown;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When defining an array type we always use Array<T> and not T[] by convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants