-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Labels
developmentStandard developmentStandard developmentr&d:polykey:supporting activitySupporting core activitySupporting core activity
Description
Specification
When calling cancel()
on a Timer
to clean it up, the underlying node timer is not cleared with clearTimeout()
and the Timer
promise never resolves or rejects. The prevents the process from ending until the timer delay has passed.
To reproduce this take the following steps.
- Create a
Timer
with 10 seconds delay. - cancel the timer with any reason.
- check if the timer rejects with provided reason immediately.
- Check that the underlying node timer is cleaned up with
clearTimeout()
. This should be the case if theTimer
rejected or resolved. - Check that the process is not held open after the timer is cancelled.
I haven't tested this problem in this code base yet. It seems odd that this would be a problem or hasn't been tested. There may be something weird going on.
Additional context
Tasks
- Check if
Timer
is properly cleaning up when cancelled. - add tests checking this condition.
- Apply any fix if needed.
Metadata
Metadata
Assignees
Labels
developmentStandard developmentStandard developmentr&d:polykey:supporting activitySupporting core activitySupporting core activity