Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NodeJS 0.12 #217

Closed
wants to merge 1 commit into from
Closed

Support NodeJS 0.12 #217

wants to merge 1 commit into from

Conversation

kuraga
Copy link
Contributor

@kuraga kuraga commented Apr 4, 2015

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.49% when pulling 99126ae on kuraga:support-nodejs-012-and-iojs into 1186cdc on Matt-Esch:master.

@kuraga kuraga changed the title Support NodeJS 0.12 and io.js Support NodeJS 0.12 Apr 4, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.49% when pulling 18c9ddc on kuraga:support-nodejs-012-and-iojs into 1186cdc on Matt-Esch:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.49% when pulling 18c9ddc on kuraga:support-nodejs-012-and-iojs into 1186cdc on Matt-Esch:master.

@kuraga
Copy link
Contributor Author

kuraga commented Apr 4, 2015

io.js fails: https://travis-ci.org/Matt-Esch/virtual-dom/jobs/57133430
Any ideas about it?

@Matt-Esch
Copy link
Owner

This is probably a bug in tap-spec (I've seen the same thing on windows and mac, but never linux). It's something to do with (a)sync writes with console.log vs fs.write(Sync).

Would be good to update tap-spec to latest to see if the bug has been fixed, if not I'd prefer a pr on tap-spec over removing it.

@jails
Copy link
Contributor

jails commented Apr 7, 2015

Should be solved in #225

@Matt-Esch Matt-Esch closed this Apr 15, 2015
@Matt-Esch
Copy link
Owner

merged #225

@kuraga kuraga deleted the support-nodejs-012-and-iojs branch April 15, 2015 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants