Group 1 Review #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinLebo
reviewed
Jan 17, 2025
|
|
||
| import colorbrewer from 'colorbrewer'; | ||
|
|
||
| var iconv = require('iconv-lite'); |
JustinLebo
reviewed
Jan 17, 2025
| const MapElement = () => { | ||
|
|
||
| // console.log(colorbrewer.schemeGroups.sequential); | ||
| // console.log(colorbrewer) |
|
|
||
| import { TileProviders } from '../lib/TileProviders'; | ||
|
|
||
| import colorbrewer from 'colorbrewer'; |
There was a problem hiding this comment.
two spaces after import, awful
JustinLebo
reviewed
Jan 17, 2025
|
|
||
| const handleFile = (e) => { | ||
| var reader = new FileReader(); | ||
| var file = e.target.files[0]; |
JustinLebo
reviewed
Jan 17, 2025
| else { | ||
| if ( !apiKey || apiKey !== 'none') { | ||
| return ( | ||
| <BaseLayer key={index} name={providerName}> |
There was a problem hiding this comment.
Is there not anything else we can use for the key?
cnix45
reviewed
Jan 17, 2025
| } | ||
|
|
||
|
|
||
| // console.log(providerName + ":" + tileUrl) |
| var varUrl = variant.url ? variant.url : tileUrl; | ||
|
|
||
|
|
||
| // console.log( " -- varFullName: " + varFullName + ": " + varUrl); |
JustinLebo
reviewed
Jan 17, 2025
|
|
||
| <Marker position={map !== null ? map.getCenter() : center} draggable={true} animate={true}> | ||
| <Popup> | ||
| A pretty CSS3 popup. <br /> Easily customizable. |
JustinLebo
reviewed
Jan 17, 2025
|
|
||
| return ( | ||
|
|
||
| Object.keys(variants).map((varName, varIdx) => { |
There was a problem hiding this comment.
Can you change these to variantName, and variantIndex? Var seems too much like Javascript var keyword.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Map Element that allows you to toggle through different types of tiles.