Skip to content

Conversation

scott-david-walker
Copy link
Contributor

No description provided.

@Matthiee Matthiee added the enhancement New feature or request label Jan 13, 2025
@Matthiee Matthiee assigned Matthiee and unassigned Matthiee Jan 13, 2025
@Matthiee Matthiee self-requested a review January 13, 2025 08:05
Copy link
Member

@Matthiee Matthiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @scott-david-walker thank you for your PR.

I reviewed it, some small changes are required before this can get merged.

  • Regenerate model
  • Add the endpoint to IFinancialModelingPrepApiClient
  • Update ResolveApiTests
  • Update ClientFactoryTests

@scott-david-walker
Copy link
Contributor Author

Fixed the issues. Didn't generate the model again but double checked the properties and also whether I got data from them all. All seems to be in order.

Cheers

@Matthiee Matthiee enabled auto-merge (squash) January 13, 2025 20:47
Copy link
Member

@Matthiee Matthiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scott-david-walker LGTM! Thank you for your contribution.

@Matthiee Matthiee merged commit 03fd7de into MatthiWare:master Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants