Added keyUp events & CapsLock synchronization; refactored handling of events
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
August 31, 2020 01:31
…canCodes to most events
…tation for 4 spaces
MaxGyver83
approved these changes
Sep 15, 2020
| @@ -2,8 +2,8 @@ | |||
| # Layout: neo, adnw, adnwzjf, bone, koy, kou, vou, qwertz | |||
| layout=neo | |||
|
|
|||
| # use quote/� as right level 3 modifier | |||
| # �-Taste als rechten Ebene3-Modifier verwenden | |||
| # use quote/ä as right level 3 modifier | |||
There was a problem hiding this comment.
What have you changed here? I don't see any difference. Is it the file encoding?
There was a problem hiding this comment.
da war glaub echt was anders am file encoding. So wies jetzt ist, stimmt es glaub
There was a problem hiding this comment.
it showed � for all the umlaute for me, so I just added the Umlaute again by keyboard (and something changed, I guess 🤷)
| @@ -142,6 +148,45 @@ void mapLevels_2_5_6(TCHAR * mappingTableOutput, TCHAR * newChars) | |||
| } | |||
| } | |||
|
|
|||
| void initLevel4SpecialCases() { | |||
There was a problem hiding this comment.
Initializing this makes sense definitely!
| @@ -383,29 +467,28 @@ bool handleLayer3SpecialCases(KBDLLHOOKSTRUCT keyInfo) | |||
| return true; | |||
| case 20: | |||
| sendChar(L'^', keyInfo); | |||
| keybd_event(VK_SPACE, 0x39, 0, 0); | |||
| commitDeadKey(keyInfo); | |||
There was a problem hiding this comment.
Just a side note: I just noticed that I only get spaces instead of ^ in Neovim (same for backticks). But this also occurs with the official release. So not caused by your changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a go at fixing the things that didn't work properly and bothered me (and others, it seems) and actually managed to do so. These are the changes summarized:
keyUpevents (and combined it withkeyDown)scanCodeto manually sent key eventsShiftLockandCapsLockwith windowsCapsLockstate.CapsLockkeypress when togglingShiftLockorCapsLockbypassMode, so whenbypassMode=trueandCapsLockis pressed, it will also be enabled when switching back tobypassMode=falseinitLayoutI have been using this for 2 weeks now and haven't noticed any problems in daily use (though while gaming I always had it disabled because the modifier keys don't behave how they'd need to for those programs - for me at least).