Fix mapping of extended key codes #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timokroeger Thanks for your pull request! @fw623 You added the handling of |
|
I tried it a bit and didn't find any problems with it. Though I also didn't have any problems without this change. So for me it's good to go, at least that part of the PR. |
MaxGyver83
requested changes
Nov 20, 2020
There was a problem hiding this comment.
You should revert commit 998dd8e (or maybe you find a better replacement for str2wcs/MultiByteToWideChar).
Key up events have an additional bit set in the flags. Because the the key press was not identified as an extended scan code it was falsely remapped. Example: Arrow Keys especially navigation shortcuts like ALT+left or ALT+right did not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key up events have an additional bit set in the flags. Because the the key press was not identified as an extended scan code it was falsely remapped.
Example: Arrow Keys especially navigation shortcuts like ALT+left or ALT+right did not work.