[framework] PK: try storing all private RSA keys in PSA (1/3) #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriosetti
changed the title
This was referenced Jun 5, 2025
valeriosetti
added
needs-ci
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
valeriosetti
force-pushed
the
issue298-framework
branch
from
563a3b3 to
2b62f29
Compare
valeriosetti
changed the title
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
The previous key had only 518 bits for E. Being not a multiple of 8 this didn't allow the key to be imported into PSA. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
valeriosetti
force-pushed
the
issue298-framework
branch
from
2b62f29 to
aa5018d
Compare
|
Only Windows failures left in the CI, but all of them are related to the CI, not to the code, so I'm going to remove the |
valeriosetti
added
needs-review
gilles-peskine-arm
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
LGTM, assuming that Mbed-TLS/TF-PSA-Crypto#308 does the right thing (I haven't reviewed it yet).
felixc-arm
approved these changes
Jun 24, 2025
Comment on lines
1397
to
1404
| case MBEDTLS_PK_RSA: | ||
| #if defined(MBEDTLS_PK_USE_PSA_RSA_DATA) | ||
| TEST_ASSERT(PSA_KEY_TYPE_IS_RSA(psa_type)); | ||
| pk_public = pk->pub_raw; | ||
| pk_public_length = pk->pub_raw_len; | ||
| break; | ||
| #else /* MBEDTLS_PK_USE_PSA_RSA_DATA */ | ||
| TEST_ASSERT(PSA_KEY_TYPE_IS_RSA(psa_type)); |
There was a problem hiding this comment.
Minor nit - could probably have moved the duplicated TEST_ASSERT out of the #if defined but only a minor code style thing.
github-project-automation
bot
moved this from In Development
to Has Approval
in Roadmap pull requests (new board)
felixc-arm
added
approved
github-project-automation
bot
moved this from Has Approval
to Done
in Roadmap pull requests (new board)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Helps resolving Mbed-TLS/TF-PSA-Crypto#298
This is PR 1 out of 3 for this series to solve that issue
Shadow PR with everything: Mbed-TLS/mbedtls#10228
PR checklist
development