-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HEADER_SEARCH_PATHS and EXTRA_LIBRARY_SEARCH_PATHS #727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for opening this pull request!
I found a few things that I either missed or just didn't think about earlier. Let me know if something is not clear. I'm also happy to push fixup commits if you want.
I updated the PR based on your comments, hope I did not miss too much this time ! the pipeline is failing because of the changes in the generated CMakeLists.txt, but I don't think I can get the artefacts from the pipeline, you probably have to do that |
Btw I did not format the code because it was also changing other parts of the code, the CI does not seem to check this file either |
@Riuzakiii Thanks a lot for addressing my comments quickly! I pushed several fixup commits to address some more "comments" I would have. I hope you don't mind.
Indeed, I pushed 74905a8 to address that (please keep it as a separate commit).
Very good catch ! 👏🏻 |
No problem, I don't mind at all ! I will rebase the branch after you merge #728 and keep the changes of the generated file as a separate commit. |
@Riuzakiii thanks for rebasing! |
They were relative to the jucer folder instead of project folder
@Riuzakiii I rebased one last time to slightly reword the first commit (I did the same thing for the PR title), and I also pushed a final commit to add you to the table of contributors. Please have a look and double check that what I wrote is correct, thanks! |
Looks good to me, thanks for adding me to the table of contributors |
They were relative to the jucer folder instead of project folder
Fixes #726