Skip to content

Fix build with Python 3.13 #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Fix build with Python 3.13 #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e785a4d
Fix build with Python 3.13 see https://github.com/MeVisLab/pythonqt/i…
FabioLolix Dec 28, 2024
cfc44ff
Update build.yml to python 3.13
FabioLolix Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ jobs:
# msvc-toolset: '14.16'

- qt-arch: 'win64_msvc2019_64'
python-version: '3.12'
python-version: '3.13'
python-arch: 'x64'
qt-version: '5.15.*'
pythonqtall-config: 'PythonQtCore PythonQtGui PythonQtMultimedia'
Expand Down
6 changes: 0 additions & 6 deletions src/PythonQt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,12 +348,6 @@ PythonQt::PythonQt(int flags, const QByteArray& pythonQtModuleName)
Py_Initialize();
}

#ifdef PYTHONQT_FULL_THREAD_SUPPORT
if (!PyEval_ThreadsInitialized()) {
PyEval_InitThreads();
}
#endif

// add our own python object types for qt object slots
if (PyType_Ready(&PythonQtSlotFunction_Type) < 0) {
std::cerr << "could not initialize PythonQtSlotFunction_Type" << ", in " << __FILE__ << ":" << __LINE__ << std::endl;
Expand Down