Add isatty() method to PythonQtStdIn class #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @lassoan Could you update the commit to include the following: For reference, here is a similar commit we contributed back almost 10 yrs ago ... commontk/PythonQt@7132dba |
This was already in the commit comment. |
Issue is that the Add isatty() method to PythonQtStdIn class
pip and some other Python modules use this attribute to check if they are running in an interactive console.
+
+ fixes #48
+
Co-authored-by: Fernando Perez-Garcia <fernando.perezgarcia.17@ucl.ac.uk>
-
- fixes #48 |
pip and some other Python modules use this attribute to check if they are running in an interactive console. fixes MeVisLab#48 Co-authored-by: Fernando Perez-Garcia <fernando.perezgarcia.17@ucl.ac.uk>
lassoan
force-pushed
the
48-add-isatty-to-stdin-upstream
branch
from
3b58d29 to
bc65dba
Compare
|
I did not know that the order matter. I've moved the coauthor message to the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip and some other Python modules use this attribute to check if they are running in an interactive console.
Co-authored-by: Fernando Perez-Garcia fernando.perezgarcia.17@ucl.ac.uk
fixes #48