Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Container Style when applied twice - MEED-3024 - Meeds-io/meeds#1351 #722

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

boubaker
Copy link
Member

@boubaker boubaker commented Dec 1, 2023

This change will avoid applying the margin twice when the CSS Class helper singlePageApplication is applied in container and on application. Applying it on application will ensure to always have the same Look and feel when adding it using a layout management. Addming it in a container will ensure to have the same ratio of page independing from the pplications added into it.

…eds#1351

This change will avoid applying the margin twice when the CSS Class helper singlePageApplication is applied in container and on application.
Applying it on application will ensure to always have the same Look and feel when adding it using a layout management. Addming it in a container will ensure to have the same ratio of page independing from the pplications added into it.
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@boubaker boubaker enabled auto-merge (squash) December 4, 2023 13:59
@boubaker boubaker merged commit 0fa4e21 into develop Dec 4, 2023
6 checks passed
@boubaker boubaker deleted the meed-3024-dev branch December 4, 2023 14:04
rdenarie pushed a commit that referenced this pull request Dec 5, 2023
…eds#1351 (#722)

This change will avoid applying the margin twice when the CSS Class
helper singlePageApplication is applied in container and on application.
Applying it on application will ensure to always have the same Look and
feel when adding it using a layout management. Addming it in a container
will ensure to have the same ratio of page independing from the
pplications added into it.
rdenarie pushed a commit that referenced this pull request Dec 5, 2023
…eds#1351 (#722)

This change will avoid applying the margin twice when the CSS Class
helper singlePageApplication is applied in container and on application.
Applying it on application will ensure to always have the same Look and
feel when adding it using a layout management. Addming it in a container
will ensure to have the same ratio of page independing from the
pplications added into it.
rdenarie pushed a commit that referenced this pull request Dec 6, 2023
…eds#1351 (#722)

This change will avoid applying the margin twice when the CSS Class
helper singlePageApplication is applied in container and on application.
Applying it on application will ensure to always have the same Look and
feel when adding it using a layout management. Addming it in a container
will ensure to have the same ratio of page independing from the
pplications added into it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants