Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Container Style when applied twice - MEED-3024 - Meeds-io/meeds#1351 #725

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

rdenarie
Copy link
Member

@rdenarie rdenarie commented Dec 5, 2023

This change will avoid applying the margin twice when the CSS Class helper singlePageApplication is applied in container and on application. Applying it on application will ensure to always have the same Look and feel when adding it using a layout management. Addming it in a container will ensure to have the same ratio of page independing from the pplications added into it.

…eds#1351 (#722)

This change will avoid applying the margin twice when the CSS Class
helper singlePageApplication is applied in container and on application.
Applying it on application will ensure to always have the same Look and
feel when adding it using a layout management. Addming it in a container
will ensure to have the same ratio of page independing from the
pplications added into it.
@github-actions github-actions bot added the partialCIBuild Perform Partial CI Build label Dec 5, 2023
@rdenarie rdenarie requested a review from azayati December 5, 2023 17:19
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@azayati azayati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azayati azayati changed the title fix: Fix Container Style when applied twice - MEED-3024 - Meeds-io/me… fix: Fix Container Style when applied twice - MEED-3024 - Meeds-io/meeds#1351 Dec 5, 2023
@rdenarie rdenarie merged commit 8e75200 into stable/6.5.x-exo Dec 6, 2023
6 checks passed
@rdenarie rdenarie deleted the backport-fix-maintenance-20231205 branch December 6, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants