lightning storm updates #5436
lightning storm updates #5436
Conversation
kuronekochomusuke
commented
Apr 29, 2024
•
kuronekochomusuke
commented
- update lightning storm effects
- resolve end turn lightning storm damage
- option to target units
|
This looks awesome and fun |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
what do you think about a option to randomly hit a spot containing a unit? I implemented it as a random hex on the board, and with a large map it is not likely to hit anything. the rule says using any manner the players agree on for the locations. |
|
I like it. Mechs as lightning rods. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5436 +/- ##
============================================
- Coverage 29.07% 29.07% -0.01%
- Complexity 13971 13973 +2
============================================
Files 2601 2601
Lines 267426 267493 +67
Branches 47744 47761 +17
============================================
+ Hits 77766 77769 +3
- Misses 185763 185827 +64
Partials 3897 3897 ☔ View full report in Codecov by Sentry. |
| } | ||
|
|
||
| List<Entity> hitEntities = game.getEntitiesVector().stream() | ||
| .filter(e -> e.getPosition().equals(coords) |
There was a problem hiding this comment.
getPosition can return null, better turn this comparison around
There was a problem hiding this comment.
also, should the lightning storm disregard offboard units?
There was a problem hiding this comment.
by default it only targets a on board hexes.
adding off board hexes would make hitting anything very rare, since you can have units sheets away from the main board.
if you use the option to target units, it will target off board units also if they have a posiition.
for gun emplacements I was thinking the building takes the damage. that is what it looks like it does for other damage types.
|
Let me know if the changes are done. Aiming to get some merged in for the nightly. |
|
it is done |
