Industrial tripod cockpit #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoancient
commented
Mar 28, 2024
| @@ -137,8 +137,6 @@ public void createNewUnit(long entityType, boolean isPrimitive, boolean isIndust | |||
| mech.addEngineCrits(); | |||
| if (isPrimitive) { | |||
| mech.addPrimitiveCockpit(); | |||
| } else if (isIndustrial) { | |||
There was a problem hiding this comment.
I removed this branch because it is incorrectly adding a standard industrial cockpit to tripods and superheavies, and already handled correctly in Mech::addCockpit in the else branch below.
megameklab/src/megameklab/printing/reference/GroundToHitMods.java
Outdated
Show resolved
Hide resolved
pavelbraginskiy
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a distinction between tripod industrial mechs with and without active fire control. Also fixes a couple of bugs I noticed during testing, involving cockpit type not updating when switching an industrial mech to tripod or switching between standard weight and superheavy.
Requires MegaMek/megamek#5291.
Fixes #1315
Fixes #1371