Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MM's new UnitNameTracker for name collisions #2445

Conversation

sixlettervariables
Copy link
Contributor

@sixlettervariables sixlettervariables commented Feb 27, 2021

This switches to using MegaMek's new UnitNameTracker to avoid name collisions for a campaign.

Depends on MegaMek/megamek#2632

@sixlettervariables sixlettervariables added this to the 0.49-dev milestone Feb 27, 2021
@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #2445 (86abed2) into master (8404d38) will increase coverage by 0.02%.
The diff coverage is 17.24%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2445      +/-   ##
============================================
+ Coverage     10.32%   10.34%   +0.02%     
- Complexity     3406     3417      +11     
============================================
  Files           673      673              
  Lines         94656    94658       +2     
  Branches      15926    15926              
============================================
+ Hits           9771     9795      +24     
+ Misses        83511    83500      -11     
+ Partials       1374     1363      -11     
Impacted Files Coverage Δ Complexity Δ
MekHQ/src/mekhq/campaign/mission/BotForce.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ign/mission/atb/AtBScenarioModifierApplicator.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
MekHQ/src/mekhq/campaign/Campaign.java 11.33% <33.33%> (+0.13%) 94.00 <1.00> (+1.00)
MekHQ/src/mekhq/campaign/unit/Unit.java 20.38% <100.00%> (+0.05%) 207.00 <0.00> (ø)
MekHQ/src/mekhq/campaign/universe/Planet.java 26.30% <0.00%> (+0.22%) 25.00% <0.00%> (ø%)
MekHQ/src/mekhq/campaign/mission/AtBContract.java 19.22% <0.00%> (+0.23%) 65.00% <0.00%> (+2.00%)
...ekhq/campaign/universe/RandomFactionGenerator.java 60.16% <0.00%> (+1.65%) 64.00% <0.00%> (+2.00%)
...ekHQ/src/mekhq/campaign/market/ContractMarket.java 59.84% <0.00%> (+2.36%) 115.00% <0.00%> (+6.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8404d38...cc98ee6. Read the comment docs.

@sixlettervariables sixlettervariables merged commit 00db4b9 into MegaMek:master Mar 17, 2021
@sixlettervariables sixlettervariables deleted the issue-2597-protect-duplicate-name-hash branch March 17, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants