Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Recursive Node Reader in Force.java #4727

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Simplified recursive depth calculation in getMaximumDepth and improved the method populateFormationLevelsFromOrigin by combining related logic. Also adjusted the populateOriginNode function to return an integer.

Also removed a couple of 'tabs' that somehow snuck in at some point over the past couple of years.

Closes #4713

Simplified recursive depth calculation in `getMaximumDepth` and improved the method `populateFormationLevelsFromOrigin` by combining related logic. Also adjusted the `populateOriginNode` function to return an integer.
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.80%. Comparing base (ce35073) to head (c0db70b).
Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4727   +/-   ##
=========================================
  Coverage     10.80%   10.80%           
- Complexity     5712     5713    +1     
=========================================
  Files           950      950           
  Lines        131289   131274   -15     
  Branches      19136    19134    -2     
=========================================
+ Hits          14186    14187    +1     
+ Misses       115879   115862   -17     
- Partials       1224     1225    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@NickAragua NickAragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going forward, if you have an excessive number of line break changes, can you either a) roll those back or b) call out where the actual changes are? Sorting through the line breaks and spacing changes makes it difficult to identify where the actual code changes are.

@IllianiCBT IllianiCBT merged commit 8fd8323 into MegaMek:master Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MekHQ-0.50.0-SNAPSHOT: Formation Type not Auto Set for Lance Level Formations
3 participants