Update SeriouslyCommands.py -- faster Fibonacci #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did you replace the calculated |
|
Because the precision is only that far anyway. Replace it back if you like. |
|
True, but if somehow the maximum precision went up, calculating it would allow for greater precision than a float constant. Additionally, keeping it as a calculated constant means less magic numbers. |
|
If you haven't noticed, I sneaked Lucas number in (per this). Which key would you assign it to? |
|
I haven't decided if I'm going to put Lucas numbers in the standard library or include them in a supplemental library yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.