feat: Add new private_key & passphrase based authentication method #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
requested changes
Aug 22, 2024
Co-authored-by: Edgar Ramírez Mondragón <16805946+edgarrmondragon@users.noreply.github.com>
|
Thanks @haleemur! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tap can now connect to snowflake using a provided private key and passphrase. The private key can be provided as a string or the path to the private key file can be provided.
Fixes an edge-case handling where schemas needing quotes (example:
"MySpecial.SchemaName") are properly handled during discovery.Speeds up discovery slightly when
tablesis provided. The speed up is achieved by only inspecting relevant schemas which can be derived by parsing each table withintables.Introduces 3 new config parameters to support key based authentication and since there are 2 ways to authenticate,
passwordis now an optional parameter. The new parameters are:private_keyprivate_key_pathprivate_key_passphraseresolves: #19