Fix report generation #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varmar05
reviewed
Mar 24, 2022
|
If we add/delete table to geopackage would not it result in breaking change (from geodiff point of view)? I am wondering if we even pass correct full gpkg with its schema it that case? @wonder-sk |
PeterPetrik
approved these changes
Mar 28, 2022
if you delete/add table it is schema change for geodiff, see: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we parse geodiff changeset to create report some tables might not be present in the changeset (either because they were deleted or not affected by the change). This results in invalid table object and leads to the error reported in MerginMaps/qgis-plugin#362.
Refs MerginMaps/qgis-plugin#362