Skip to content

Fix typing notation #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

Fix typing notation #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions mergin/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
import typing
import warnings

from typing import List

from .common import (
ClientError,
LoginError,
Expand Down Expand Up @@ -273,7 +271,7 @@ def get(self, path, data=None, headers={}, validate_auth=True):
request = urllib.request.Request(url, headers=headers)
return self._do_request(request, validate_auth=validate_auth)

def post(self, path, data=None, headers={}, validate_auth=True, query_params: dict[str, str] = None):
def post(self, path, data=None, headers={}, validate_auth=True, query_params: typing.Dict[str, str] = None):
url = urllib.parse.urljoin(self.url, urllib.parse.quote(path))
if query_params:
url += "?" + urllib.parse.urlencode(query_params)
Expand Down Expand Up @@ -1328,7 +1326,7 @@ def get_workspace_member(self, workspace_id: int, user_id: int) -> dict:
resp = self.get(f"v2/workspaces/{workspace_id}/members/{user_id}")
return json.load(resp)

def list_workspace_members(self, workspace_id: int) -> List[dict]:
def list_workspace_members(self, workspace_id: int) -> typing.List[dict]:
"""
Get a list of workspace members
"""
Expand Down Expand Up @@ -1359,7 +1357,7 @@ def remove_workspace_member(self, workspace_id: int, user_id: int):
self.check_collaborators_members_support()
self.delete(f"v2/workspaces/{workspace_id}/members/{user_id}")

def list_project_collaborators(self, project_id: str) -> List[dict]:
def list_project_collaborators(self, project_id: str) -> typing.List[dict]:
"""
Get a list of project collaborators
"""
Expand Down