Skip to content

Return OLD server only for 404 resp #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2025
Merged

Return OLD server only for 404 resp #278

merged 2 commits into from
Sep 24, 2025

Conversation

harminius
Copy link
Contributor

@harminius harminius commented Sep 22, 2025 •
edited by MarcelGeo
Loading

@harminius
Copy link
Contributor Author

@tomasMizera Do you mean when /config does not exist on the server, right?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17915176113

Details

  • 4 of 8 (50.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 80.824%
Changes Missing Coverage Covered Lines Changed/Added Lines %
mergin/client.py 4 8 50.0%
Files with Coverage Reduction New Missed Lines %
mergin/client.py 1 87.1%
Totals Coverage Status
Change from base Build 17760071482: -0.03%
Covered Lines: 3629
Relevant Lines: 4490
💛 - Coveralls

@harminius harminius requested review from MarcelGeo and removed request for tomasMizera September 22, 2025 12:46
@MarcelGeo
Copy link
Contributor

MarcelGeo commented Sep 24, 2025 •
edited
Loading

@tomasMizera Do you mean when /config does not exist on the server, right?

I think this is ok

MarcelGeo
MarcelGeo requested changes Sep 24, 2025
View reviewed changes
@MarcelGeo MarcelGeo merged commit 6c419f3 into master Sep 24, 2025
3 of 4 checks passed
@MarcelGeo MarcelGeo deleted the fix_server_type branch September 24, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelGeo MarcelGeo MarcelGeo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guess "OLD" server only if /config endpoint does not exists
3 participants
@harminius @coveralls @MarcelGeo