Asynchronous download/push/pull #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MerginProject object was moved verbatim to the new file without any changes to it.
This was referenced Feb 17, 2020
|
https://gist.github.com/wonder-sk/3150e77d3ec0912d4c4e0c8242033aea has some very basic sample code for integration into GUI EDIT: see below for updated version of the script with error handling |
varmar05
requested changes
Feb 18, 2020
|
Also updated example GUI source code to handle errors |
|
@varmar05 the issue with progress bar should be fixed now |
varmar05
approved these changes
Feb 25, 2020
|
I think we can merge it (once we have plugin part ready) @wonder-sk @saberraz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces PR #41
Adds support for asynchronous sync - i.e. to be able to start push/pull of a project, the download will run in a background thread and then when download is finished (it can be checked whether it has happened already), we do finalization of the job (which should not take long so it is in the main thread).
This should allow the GUI to 1. allow cancellation, 2. show progress.
The command line interface has been updated to have progress bar during download/push/pull and allows graceful cancellation.
The number of parallel request has been fixed to 4 so that we don't drain server resources too much. This could be modified later or made configurable. There is now a single code path unlike before with different code paths for parallel/non-parallel approach.
By the way, MerginProject object has been moved to a new file without any changes to the code.