Generate Histograms for 2D field #594

Sylviabohnenstengel · 2024-05-09T15:53:02Z

Description

generating a PDF for a 2D field looping over vertical levels

Fixes #453

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

Documentation has been updated to reflect change.
New code has tests, and affected old tests have been updated.
All tests and CI checks pass.
Added an entry to the top of docs/source/changelog.rst
Conda lock files have been updated if dependencies changed.
Marked the PR as ready to review.
has ensemble capability
AI was used

Sylviabohnenstengel · 2024-05-15T16:17:20Z

adding ensemble capability

jfrost-mo · 2024-06-25T10:16:20Z

Old branch head: 2d9ead7

github-actions · 2024-06-25T13:56:34Z

jfrost-mo · 2024-06-28T15:28:26Z

Note to self: There are a bunch of conflict markers in this branch's code that need cleaning up.

Sylviabohnenstengel · 2024-07-03T15:35:46Z

rebased the branch

Sylviabohnenstengel · 2024-07-03T16:15:41Z

code working and now need to add unit test.

Sylviabohnenstengel · 2024-07-03T17:11:30Z

GitHub Copilot used to debugfilename in assert Path("test_473718.0.png").is_file()

Sylviabohnenstengel · 2024-07-03T17:16:29Z

@daflack @jfrost-mo I suggest that James does the technical review first and once that has passed David can do the science review.

…inking new recipe into workflow, including rose meta information and rose config infromation. Adding recipe and flow files.

New recipe to calculate spatial mean on vertical levels.

…le plotting operator to plot vertical profile.

…hanges from main. include vertical line plot operator and internal function.

…gh recipe as it splits on whitespace even inside "1000, 850". even when passing in the values as [1000,850, then jinja2 introduces a white space converting to [1000, 850] and then the split function splits the list up.

…ngelog.

jfrost-mo

Plotting code changes look good. One of the include files has an unnecessary loop, and more tests need writing for the new plotting functionality.

cset-workflow/includes/deterministic_domain_mean_vertical_profile_series.cylc

cset-workflow/meta/rose-meta.conf

src/CSET/operators/plot.py

tests/operators/test_plots.py

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Sylviabohnenstengel · 2024-07-19T12:14:28Z

Plotting code changes look good. One of the include files has an unnecessary loop, and more tests need writing for the new plotting functionality.

It has the wrong statement in the loop. IT should read:
{% for model_field in PRESSURE_LEVEL_MODEL_FIELDS %}

Corrected now in 11fe6d7..8344e50

This reverts commit 8344e50.

cset-workflow/includes/deterministic_domain_mean_vertical_profile_series.cylc

…ile_series.cylc Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Sylviabohnenstengel · 2024-07-22T16:20:46Z

Plotting code changes look good. One of the include files has an unnecessary loop, and more tests need writing for the new plotting functionality.

This has been changed in the code and this version is outdated.

jfrost-mo · 2024-07-22T16:33:36Z

Test coverage look reasonable. There are still a few lines added that are uncovered, but it'll do for now.

jfrost-mo

Looks good to me. Go ahead and merge.

David approved in another comment, but forgot to dismiss the existing review.

Sylviabohnenstengel self-assigned this May 9, 2024

jfrost-mo changed the title ~~543 generate pdfs for 2d field~~ Generate PDFs for 2D field May 10, 2024

Sylviabohnenstengel added science Scientific capabilities full_review Requires a technical, scientific, and portability review labels May 15, 2024

Sylviabohnenstengel mentioned this pull request May 21, 2024

Vertical profiles of area averaged fields #567

Merged

6 tasks

jfrost-mo changed the title ~~Generate PDFs for 2D field~~ Generate Histograms for 2D field May 23, 2024

jfrost-mo changed the base branch from main to vertical_profiles_of_area_averaged_fields_494 May 24, 2024 13:16

Base automatically changed from vertical_profiles_of_area_averaged_fields_494 to main May 29, 2024 09:07

jfrost-mo force-pushed the 543_generate_pdfs_for_2d_field branch from 2d9ead7 to ba36195 Compare June 25, 2024 10:16

Sylviabohnenstengel mentioned this pull request Jun 26, 2024

generate histograms for 2D fields on vertical levels #453

Closed

12 tasks

Sylviabohnenstengel force-pushed the 543_generate_pdfs_for_2d_field branch from b60b1d6 to 53bd5d4 Compare July 3, 2024 14:38

Sylviabohnenstengel marked this pull request as ready for review July 3, 2024 17:14

Sylviabohnenstengel requested review from jfrost-mo and daflack July 3, 2024 17:15

Sylviabohnenstengel added 8 commits July 5, 2024 11:03

rebase: update recipe to reflect new constraint for vertical levels.L…

1a25a86

…inking new recipe into workflow, including rose meta information and rose config infromation. Adding recipe and flow files.

Use more generic constraint for vertical level

c6c4189

New recipe to calculate spatial mean on vertical levels.

creates single cube of vertical profile. Now needs to develop linesty…

cb40eb4

…le plotting operator to plot vertical profile.

rebase: update plot operator for vertical line plotting with recent c…

add401b

…hanges from main. include vertical line plot operator and internal function.

rebase: keep changelog for vertical line plotting. added entry to cha…

b6f2d36

…ngelog.

addressing failed test with formatting in changelog.

ef8ed49

generate new recipe for PDF

d87dd9c

add lfric pdf

d045450

jfrost-mo requested changes Jul 19, 2024

View reviewed changes

Sylviabohnenstengel and others added 9 commits July 19, 2024 13:05

Update src/CSET/operators/plot.py

96ad5ee

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update src/CSET/operators/plot.py

29c6121

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update src/CSET/operators/plot.py

7e73469

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update cset-workflow/meta/rose-meta.conf

310f6bd

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update cset-workflow/meta/rose-meta.conf

cb70ee2

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update cset-workflow/meta/rose-meta.conf

3c0ebc8

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update cset-workflow/meta/rose-meta.conf

e54f5de

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update cset-workflow/meta/rose-meta.conf

11fe6d7

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

correct loop for vertical_profile include file

8344e50

Sylviabohnenstengel added 2 commits July 19, 2024 14:12

Revert "correct loop for vertical_profile include file"

ea691fd

This reverts commit 8344e50.

correct loop for vertical line plot in include file

4477719

jfrost-mo reviewed Jul 19, 2024

View reviewed changes

cset-workflow/includes/deterministic_domain_mean_vertical_profile_series.cylc Outdated Show resolved Hide resolved

Sylviabohnenstengel and others added 6 commits July 19, 2024 14:40

Update cset-workflow/includes/deterministic_domain_mean_vertical_prof…

e27301a

…ile_series.cylc Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

test grud function for number of subplots for histogram_postage_stamsps

fb7b20c

Update cset-workflow/meta/rose-meta.conf

9840b59

test for histogram

25b70d3

Test postage_stamp_histogram as black box

15dc5e1

Merge branch 'main' into 543_generate_pdfs_for_2d_field

d5122b0

jfrost-mo added 3 commits July 22, 2024 17:28

Add test for multiline histogram plotting

5fd6cd3

Simplify stamp_coordinate check

09f04f9

Merge branch 'main' into 543_generate_pdfs_for_2d_field

9a0cce3

jfrost-mo approved these changes Jul 22, 2024

View reviewed changes

jfrost-mo merged commit cce0d35 into main Jul 23, 2024
7 checks passed

jfrost-mo deleted the 543_generate_pdfs_for_2d_field branch July 23, 2024 08:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate Histograms for 2D field #594

Generate Histograms for 2D field #594

Sylviabohnenstengel commented May 9, 2024 •

edited

Loading

Sylviabohnenstengel commented May 15, 2024

jfrost-mo commented Jun 25, 2024

github-actions bot commented Jun 25, 2024 •

edited

Loading

jfrost-mo commented Jun 28, 2024

Sylviabohnenstengel commented Jul 3, 2024

Sylviabohnenstengel commented Jul 3, 2024

Sylviabohnenstengel commented Jul 3, 2024

Sylviabohnenstengel commented Jul 3, 2024

jfrost-mo left a comment

Sylviabohnenstengel commented Jul 19, 2024

Sylviabohnenstengel commented Jul 22, 2024

jfrost-mo commented Jul 22, 2024

jfrost-mo left a comment

Generate Histograms for 2D field #594

Generate Histograms for 2D field #594

Conversation

Sylviabohnenstengel commented May 9, 2024 • edited Loading

Description

Contribution checklist

Sylviabohnenstengel commented May 15, 2024

jfrost-mo commented Jun 25, 2024

github-actions bot commented Jun 25, 2024 • edited Loading

jfrost-mo commented Jun 28, 2024

Sylviabohnenstengel commented Jul 3, 2024

Sylviabohnenstengel commented Jul 3, 2024

Sylviabohnenstengel commented Jul 3, 2024

Sylviabohnenstengel commented Jul 3, 2024

jfrost-mo left a comment

Choose a reason for hiding this comment

Sylviabohnenstengel commented Jul 19, 2024

Sylviabohnenstengel commented Jul 22, 2024

jfrost-mo commented Jul 22, 2024

jfrost-mo left a comment

Choose a reason for hiding this comment

Sylviabohnenstengel commented May 9, 2024 •

edited

Loading

github-actions bot commented Jun 25, 2024 •

edited

Loading