This repository was archived by the owner on Oct 7, 2024. It is now read-only.
bump @metamask/eth-hd-keyring to v5
#177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
bump-eth-hd-keyring-to-v5
branch
from
122aa25 to
18b41e0
Compare
adonesky1
force-pushed
the
bump-eth-hd-keyring-to-v5
branch
from
18b41e0 to
26241c6
Compare
Gudahtt
approved these changes
Dec 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps
@metamask/eth-hd-keyringto v5 and modifies tests accordinglyThere are a number of breaking changes associated with this version bump, but the
KeyringControlleris already adapted to all such changes with the exception of expecting a publicwalletsproperty on the HDKeyring in a couple of tests. Those instances have been modified accordingly.