feat(controller-utils): support BigNumber as input to BNToHex #4827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
legobeat
force-pushed
the
bignumbertohex
branch
3 times, most recently
from
2545fe4 to
9826643
Compare
legobeat
added
the
team-wallet-framework
legobeat
force-pushed
the
bignumbertohex
branch
4 times, most recently
from
fd704e0 to
7f8c90f
Compare
legobeat
force-pushed
the
bignumbertohex
branch
from
9312c2a to
15d7a43
Compare
mikesposito
approved these changes
Oct 23, 2024
mcmire
reviewed
Oct 23, 2024
| "devDependencies": { | ||
| "@metamask/auto-changelog": "^3.4.4", | ||
| "@types/jest": "^27.4.1", | ||
| "bignumber.js": "^4.1.0", |
There was a problem hiding this comment.
@legobeat Should this have been added to dependencies instead of devDependencies? It seems like it's being used in a public file.
There was a problem hiding this comment.
I think that bignumber.js is only used to pull the BigNumber type, because bn.js is used for the actual runtime conversion implementation
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The API for this part is equivalent between the two libraries. Allowing both eases migrations.
References
Related
Changelog
@metamask/controller-utilsbignumber.jsinstances are valid input toBNToHex.Checklist