feat: Make breaking changes to next base-controller metadata

[Gudahtt]

Explanation

Make the planned breaking changes to controller metadata. This includes renaming anonymous to includeInDebugSnapshot, and it includes making the two new metadata properties required.

References

Relates to #6443

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

[cursor]

Bug: Metadata Constraint Mismatch

The StatePropertyMetadataConstraint type is out of sync with StatePropertyMetadata. It still uses the anonymous property instead of includeInDebugSnapshot, and includeInStateLogs and usedInUi are optional instead of required. This breaks its intended supertype relationship, causing type incompatibility.

packages/base-controller/src/next/BaseController.ts#L109-L120

core/packages/base-controller/src/next/BaseController.ts

Lines 109 to 120 in 1474ccc

	/**
	* A universal supertype of `StatePropertyMetadata` types.
	* This type can be assigned to any `StatePropertyMetadata` type.
	*/
	export type StatePropertyMetadataConstraint = {
	anonymous: boolean | StateDeriverConstraint;
	includeInStateLogs?: boolean | StateDeriverConstraint;
	persist: boolean | StateDeriverConstraint;
	usedInUi?: boolean;
	};

 

---

[cryptodev-2s]

LGTM!