Discourage postponing release of changed packages #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
commented
Aug 4, 2022
| } | ||
|
|
||
| const errors: { message: string | string[]; lineNumber: number }[] = []; | ||
| const errors: { message: string | string[]; lineNumber?: number }[] = []; |
There was a problem hiding this comment.
I have plans to refactor this function as I know it's getting a bit out of hand. Sorry that this is hard to read in the meantime.
mcmire
force-pushed
the
only-list-changed-packages
branch
from
6c124d0 to
34ccbf1
Compare
mcmire
force-pushed
the
restrict-to-changed-packages
branch
from
0ba3ffd to
68165a3
Compare
|
Rebased! |
mcmire
force-pushed
the
only-list-changed-packages
branch
2 times, most recently
from
3b55821 to
00b7396
Compare
When the tool generates a release spec, it will list all packages that have changed since their last release. Editing the release spec to remove a package so that it is no longer included in the release is potentially dangerous, because it means that any package which relies on that package that *is* included in the release could be broken in production. Since it's sometimes necessary to delay the release of a package, this commit changes the release spec validation step such that if it detects that a package that should be listed in the release spec *isn't*, it will throw an error, advising the user of the danger, yet provide a hidden option should the user really want to proceed.
mcmire
force-pushed
the
restrict-to-changed-packages
branch
from
68165a3 to
6bf8b36
Compare
|
Rebased again. |
Gudahtt
previously approved these changes
Oct 4, 2022
|
The hidden "intentionally-skip" flag seems like a great idea. It's well documented, but only in the case you run into it. Good compromise for something we want to discourage. |
Gudahtt
reviewed
Oct 5, 2022
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the tool generates a release spec, it will list all packages that
have changed since their last release. Editing the release spec to
remove a package so that it is no longer included in the release is
potentially dangerous, because it means that any package which relies on
that package that is included in the release could be broken in
production.
Since it's sometimes necessary to delay the release of a package, this
commit changes the release spec validation step such that if it detects
that a package that should be listed in the release spec isn't, it
will throw an error, advising the user of the danger, yet provide a
hidden option should the user really want to proceed.
Fixes #10.